add github actions workflow #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Peveler <[email protected]>
Contributor
|
Shouldn't you also delete .travis.yml? |
Contributor
Author
|
I can, or can leave it for a "transitional period" to make sure everyone is happy with GH actions. I'm happy to do either. |
Contributor
Author
|
I forgot to mention in the above that GitHub does not support Python 3.4, but given that it's EOL anyway and no current LTS distro ships with it, I think it's fine to drop. |
Contributor
|
Alright. You can proceed with deleting .travis.yml now. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a Github Actions workflow to this project, which is identical to Travis-CI with the exception of not testing against Python Nightly. Given the simplicity of the codebase, I don't think this is a real loss of things, with the benefit that GH actions increasingly a nicer platform than Travis-CI beyond a few edge cases.