Skip to content

Changed read and write to binary mode #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 2, 2017
Merged

Changed read and write to binary mode #36

merged 1 commit into from
Mar 2, 2017

Conversation

@iliakonnov
Copy link
Contributor

@iliakonnov iliakonnov commented Feb 17, 2017

Fixes #31
Fixes #35

@waldyrious
Copy link
Member

waldyrious commented Mar 2, 2017

Thanks for the fix, @iliakonnov! I tested this locally with pip install git+https://github.com/iliakonnov/tldr-python-client.git and indeed the issue seems to be gone. At last! 😄

@waldyrious waldyrious merged commit 846e21f into tldr-pages:master Mar 2, 2017
@waldyrious waldyrious mentioned this pull request Mar 2, 2017
Closed
This was referenced Aug 13, 2017
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iliakonnov @waldyrious