Skip to content

Conversation

@jeeftor
Copy link
Contributor

@jeeftor jeeftor commented Feb 27, 2017

Closes #11.

  • Added an environment variable that allows you to disable SSL inspection - if for some reason you wanted to do that.

@jeeftor
Copy link
Contributor Author

jeeftor commented Feb 27, 2017

This pull request adds two features:

The CI isn't working correctly but i don't know if that matters.

@waldyrious
Copy link
Member

@jeeftor the build is failing in Python 3.3 only -- perhaps you need to include some compatibility code?

tldr.py:25: in <module>

    ignore_ctx = ssl.create_default_context()

E   AttributeError: 'module' object has no attribute 'create_default_context'

@waldyrious
Copy link
Member

Also, I'd prefer if you submitted the hyphen-joining code in a separate PR, if that wouldn't be too much of a hassle :)

@felixonmars
Copy link
Collaborator

I'm ok with the idea, however, it could use a better wording than IGNORE_SSL. How about ALLOW_INSECURE?

@zlatanvasovic
Copy link
Contributor

@waldyrious Do we proceed with merging this one?

Signed-off-by: Matthew Peveler <[email protected]>
@MasterOdin
Copy link
Contributor

@zdroid @waldyrious @felixonmars I updated the PR for the requested changes and fixed merge conflicts and I think this should be good to go?

@zlatanvasovic
Copy link
Contributor

Good work here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow to turn ssl_verify off?

5 participants