Skip to content

Conversation

@clesecq
Copy link

@clesecq clesecq commented Apr 23, 2020

The majority of clients that allow to update their cache use --update, this allows to keep a certain unity. One of the consequences encountered with topgrade (utility trying to update the program maximum), not knowing which clients are facing it, it tries the most common method.

Copy link
Contributor

@zlatanvasovic zlatanvasovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you missed line 264 in the same file. This way it definitely doesn't work.

(update_cache has to be renamed everywhere)

@clesecq
Copy link
Author

clesecq commented Apr 24, 2020

After a closer look, the ArgParse library considers that passing --update as an argument is the same as passing --update_cache. So I close this pull request, which is no longer necessary.

@clesecq clesecq closed this Apr 24, 2020
@clesecq clesecq changed the title Change --update_cache to --update Unnecessary change --update_cache to --update Apr 24, 2020
@zlatanvasovic
Copy link
Contributor

@StelFux Thanks for the work on this nevertheless. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants