-
-
Notifications
You must be signed in to change notification settings - Fork 109
Use default terminal colors instead of white by default #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Matthew Peveler <[email protected]>
Signed-off-by: Matthew Peveler <[email protected]>
|
Works great for me, but do we want to set |
|
@KyleWJohnston It's compatible with the way colors are done in Bash. If you specify none, it's set to default. |
|
Whoops, I was looking at the wrong branch. It works without configuration for me too. |
|
@MasterOdin @KyleWJohnston I think blank color can be dropped altogether, as it's supposed to be... blank. I'm working in #98 on simplifying the way that pages are displayed. |
|
I suspect the idea of the blank variable is that if you wanted to give a colored background for the entire output, you would want to set the background there. Like, in #20, if you just outputted an empty line, then the lines with no text would have a black background while the other lines would still have blue background here and there, and it would look like a mess. |
|
@MasterOdin Check the latest change. It should be highlighted perfectly now. |
|
@zdroid Given that this PR is necessary to get colors and attributes working as expected (and from environment variables), and have a meaningful discussion on |
|
Fair point, I realized that too after making the changes. |
Closes #95
Closes #94 (sorta)
Removes the white default color from TLDR commands, as well as allows you to specify a blank string for one of the colors and it will work as expected by using the default color from the terminal.
This also fixes an issue where if you could only one word in the environment string and not a combination of things as the
user_value not in ACCEPTED_COLORScheck would always fail otherwise.