This repository was archived by the owner on Sep 18, 2021. It is now read-only.
Some cctld to be linkified #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -94,15 +94,16 @@ | |||
| "台灣|新加坡|香港|한국" + | |||
| ")(?=[^\\p{Alnum}@]|$))"; | |||
| private static final String URL_PUNYCODE = "(?:xn--[0-9a-z]+)"; | |||
| private static final String SPECIAL_URL_VALID_CCTLD = "(?:(?:" + "co|tv" + ")(?=[^\\p{Alnum}@]|$))"; | |||
There was a problem hiding this comment.
Can we avoid string concatenation here and just use the final "(?:(?:co|tv)(?=[^\\p{Alnum}@]|$))" string?
There was a problem hiding this comment.
Yes, we can. I was a little worried when we will have many ccTLD in here in the future :)
There was a problem hiding this comment.
Oh, I see. You can put them in a separate constant right away then. It's up to you though.
There was a problem hiding this comment.
I like the fact that it is split, easier to read :)
There was a problem hiding this comment.
Indeed, having many same string like ")(?=[^\\p{Alnum}@]|$))" isn't cool :P
|
|
|
Make sure there are at least tickets in rb/js/objc/conformance |
|
Yes, rb/js/objc are remaining. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.