Skip to content

fix: remove fallback 500 status for client errors #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kricsleo
Copy link
Member

@kricsleo kricsleo commented May 7, 2025

resolves #495

This PR removes the fallback 500 status for client errors.
❗ Noted that this might be a breaking change for users who rely on this fallback behavior.

When 500 is included in the retryStatusCodes (default):
Before and after are the same.

When 500 is excluded (manually):
Before: won't retry
After: will retry

Copy link

codecov bot commented May 7, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.82%. Comparing base (27996d3) to head (03a02e2).
Report is 67 commits behind head on main.

Files with missing lines Patch % Lines
src/fetch.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #496       +/-   ##
===========================================
+ Coverage   56.86%   69.82%   +12.96%     
===========================================
  Files          16       17        +1     
  Lines         728      527      -201     
  Branches      113      137       +24     
===========================================
- Hits          414      368       -46     
+ Misses        303      148      -155     
  Partials       11       11               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client errors are not retried when 500 is not included in retryStatusCodes
1 participant