feat(compiler): add support for Ember

[rtablada]

Description

This adds a compiler for Ember/Glimmer components as well as examples for use in both a Vite and Webpack build tooling for Ember

Linked Issues

Additional context

@NullVoxPopuli may be able to help get things over the 🏁, this was a WIP from a hackathon/side project that I have not been able to get back to.

[bolt-new-by-stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[userquin]

Run the build command, ember.d.ts types should be added to the subpackage exports at package json file.

Try to reduce both ember examples to minimal required code to test the icons 🙏 (update root .gitignore to exclude ember stuff at examples).

[NullVoxPopuli]

I can do that -- @rtablada can you add me as a collaborator on your fork? <3

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@​ember/​app-tsconfig@​1.0.3
	@​embroider/​webpack@​4.1.1
	vue-tsc@​3.1.1
	@​embroider/​compat@​3.9.1
	@​embroider/​core@​3.5.7
	@​embroider/​core@​4.2.4
	@​babel/​plugin-transform-runtime@​7.15.0 ⏵ 7.28.3			+1
	@​babel/​runtime@​7.15.4 ⏵ 7.28.4	+1	+4	+1
	@​ember/​optional-features@​2.2.0
	unplugin-vue-components@​28.8.0
	nuxt@​4.1.3
	@​embroider/​macros@​1.19.1
	@​embroider/​router@​3.0.4
	@​embroider/​vite@​1.3.2

View full report

[NullVoxPopuli]

hm, any way I can see details on why socket.io is saying my deps are bad? 😢

[NullVoxPopuli]

I thiiiink this is ready for review?
Happy to do whatever else is needed though

[userquin]

Did you run the build command from root? ./types/ember subpackage export should be added to the package.json by tsdown.

[userquin]

hm, any way I can see details on why socket.io is saying my deps are bad? 😢

I'm getting also forbidden message 🤔

Check https://socket.dev/?utm_medium=gh, you have some hints at the end of the page

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/unplugin-icons@419

commit: 2a2da4d

[userquin]

We still need the ember types at subpackage exports, just run pnpm build from root folder and push the changes added by tsdown build.

[NullVoxPopuli]

how do you mean? i did ? I think?

[userquin]

how do you mean? i did ? I think?

I was writting the comment and you push the commit 👍 now it is fine

[userquin]

Will do a review tmr from laptop

[userquin]

can you run pnpm lint from root? Maybe we need to change also eslint config file (rules)

[NullVoxPopuli]

there is a failing lint at the moment, because one of the lint rules has assumed all .map functions are Array.prototype.map 🙈

[NullVoxPopuli]

I pushed a little ignore with details about why in my most recent commit

[userquin]

Looks like ember doing weird things without test/index.html entry point (ember plugin checking some entries in the rollup configuration entry), check the error below (dev server working, only tested with Vite):

dev server error

[userquin]

once released we should add a link here https://github.com/unplugin/unplugin-icons/blob/main/examples/README.md adding the corresponding StackBlitz script file and command (at least for Vite)

[NullVoxPopuli]

check the error below (dev server working, only tested with Vite):

yea, I need to fix that 🙈 it's very easy to check if that file exists before adding the entrypoint, I just keep forgetting 🫠

we should add a link here

I can do that! <3

[NullVoxPopuli]

thanks for the reminder! embroider-build/embroider#2584 <3

[userquin]

@NullVoxPopuli can you find me at discord at antfu server unplugin-icons channel? I have a few questions about Ember and IDE support...

https://discord.gg/DMn6tWHV