Fix: Improve UI text and icon visibility in dark mode #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er visibility - Updated SectionTitleView to use primaryText color instead of bodyText - Improves visibility of section titles in Explore page - Affects all section headers including "今日热议", "最热节点", "新增节点", and "节点导航" 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Added .renderingMode(.template) to tab icons for proper tinting - Applied different opacity for selected (100%) vs unselected (60%) tab items - Icons now properly respect TintColor which switches to white in dark mode - Improved visual hierarchy with clearer selected/unselected state distinction 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR addresses dark mode visibility issues by improving color contrast for UI elements. The changes enhance readability of section titles and tab bar icons when using dark themes.
- Section titles now use higher contrast text color for better visibility
- Tab bar icons properly adapt to dark mode with template rendering and opacity-based selection states
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| V2er/View/Widget/SectionTitleView.swift | Changes section title color from bodyText to primaryText for improved contrast |
| V2er/View/Widget/TabBar.swift | Adds template rendering mode to icons and implements opacity-based selection states |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Code Coverage Report ❌Current coverage: 0% |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes visibility issues with UI elements in dark mode by improving color contrast for better readability.
Changes Made
Section title visibility fix
bodyTexttoprimaryTextfor better contrastTab bar icon improvements for dark mode
.renderingMode(.template)to tab icons to enable proper tintingTintColorwhich automatically switches to white in dark modeTesting
Screenshots
The changes improve the visibility of UI elements that were previously hard to see in dark mode due to insufficient color contrast.
Fixes visibility issues reported in dark mode usage.