Fix: Search results text colors for dark mode #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed title text to use .primaryText instead of generic .bodyText - Changed content text to use .secondaryText for better hierarchy - Removed redundant .foregroundColor modifier on parent VStack - Ensures consistent text visibility in both light and dark modes
There was a problem hiding this comment.
Pull Request Overview
This PR fixes text color adaptation issues in search results for dark mode by replacing a generic text color with more specific semantic color tokens. The changes ensure proper text visibility and visual hierarchy in both light and dark themes.
- Updated title and content text to use semantic color tokens (
.primaryTextand.secondaryText) - Removed redundant
.foregroundColor(Color.bodyText)modifier that was preventing proper color adaptation
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Code Coverage Report ❌Current coverage: 0% |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
.primaryTextfor better dark mode support.secondaryTextfor visual hierarchy.foregroundColor(Color.bodyText)modifier that was preventing proper color adaptationTest plan
🤖 Generated with Claude Code