Fix: WebView background color consistency in dark mode #25
Conversation
… mode - Updated WebView background from #111214 to #1C1C1E to match ItemBackground.colorset - Updated CSS dark mode backgrounds to use consistent colors - Changed subtle/blockquote backgrounds to #141416 for better contrast hierarchy - Ensures WebView content blends seamlessly with the app's UI in dark mode
There was a problem hiding this comment.
Pull Request Overview
This PR fixes WebView background color inconsistency in dark mode by updating both CSS and Swift code to use matching background colors. The changes ensure visual consistency between WebView content and native UI elements in the app's dark mode.
- Updates WebView background color from #111214 to #1C1C1E to match app's ItemBackground color
- Adjusts CSS dark mode backgrounds for content areas and subtle elements
- Updates Swift UIColor values to use hex-based color definitions matching the CSS changes
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| V2er/www/v2er.css | Updates dark mode background colors for topic content, subtle divs, and blockquotes |
| V2er/View/FeedDetail/HtmlView.swift | Updates WebView background color calculations to match new hex color scheme |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| webView.backgroundColor = isDark ? UIColor(red: 0x1C/255.0, green: 0x1C/255.0, blue: 0x1E/255.0, alpha: 1.0) : UIColor.white | ||
| webView.scrollView.backgroundColor = isDark ? UIColor(red: 0x1C/255.0, green: 0x1C/255.0, blue: 0x1E/255.0, alpha: 1.0) : UIColor.white |
There was a problem hiding this comment.
The color definition is duplicated across multiple lines. Consider extracting this into a constant or computed property to improve maintainability and reduce duplication.
Copilot uses AI. Check for mistakes.
| webView.backgroundColor = isDark ? UIColor(red: 0x1C/255.0, green: 0x1C/255.0, blue: 0x1E/255.0, alpha: 1.0) : UIColor.white | ||
| webView.scrollView.backgroundColor = isDark ? UIColor(red: 0x1C/255.0, green: 0x1C/255.0, blue: 0x1E/255.0, alpha: 1.0) : UIColor.white |
There was a problem hiding this comment.
This is the same color definition duplicated from the makeUIView method. The repetition increases maintenance burden when color values need to be updated.
Copilot uses AI. Check for mistakes.
Code Coverage Report ❌Current coverage: 0% |
1 participant
Summary
Problem
The WebView content area in post details had a darker background (#111214) compared to the app's ItemBackground color (#1C1C1E), creating a visual inconsistency in dark mode.
Solution
Test plan
🤖 Generated with Claude Code