-
Notifications
You must be signed in to change notification settings - Fork 574
Close on click outside #712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Close on click outside #712
Conversation
…HostListener document in click, which does the job of the directive and also checks if the user has clicked inside the component or not (changed some ngIfs for hidden to make this properly work)
Codecov Report
@@ Coverage Diff @@
## development #712 +/- ##
==============================================
+ Coverage 31.77% 31.8% +0.03%
==============================================
Files 11 11
Lines 450 459 +9
Branches 71 74 +3
==============================================
+ Hits 143 146 +3
- Misses 307 313 +6
Continue to review full report at Codecov.
|
|
@valorkin Hello! can you check if it's good to merge? |
|
@maximelafarie indeed! will be nice to get it merged but, still haven't got any response from @valorkin |
|
👍 |
|
Merge this pls... @valorkin |
|
@varrob112 Awaiting @valorkin merge it (and if it's urgent for you), you can do it your own as I done here : https://github.com/maximelafarie/ng2-select. You just need to merge the @Manny91 PR branch in the main and you're done 😉 |
|
Merge this pls... @valorkin |
|
is it resolved? :) |
Added changes for closing the options when you click outside of the component, (even if its another ng2-select component)