Skip to content

Conversation

@Manny91
Copy link

@Manny91 Manny91 commented Mar 16, 2017

Added changes for closing the options when you click outside of the component, (even if its another ng2-select component)

…HostListener  document in click, which does the job of the directive and also checks if the user has clicked inside the component or not (changed some ngIfs for hidden to make this properly work)
@Manny91 Manny91 closed this Mar 16, 2017
@Manny91 Manny91 reopened this Mar 16, 2017
@codecov-io
Copy link

codecov-io commented Mar 16, 2017

Codecov Report

Merging #712 into development will increase coverage by 0.03%.
The diff coverage is 35.71%.

Impacted file tree graph

@@              Coverage Diff               @@
##           development    #712      +/-   ##
==============================================
+ Coverage        31.77%   31.8%   +0.03%     
==============================================
  Files               11      11              
  Lines              450     459       +9     
  Branches            71      74       +3     
==============================================
+ Hits               143     146       +3     
- Misses             307     313       +6
Impacted Files Coverage Δ
src/select/select-item.ts 20.68% <0%> (-1.54%) ⬇️
src/select/select.ts 20.64% <41.66%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3afaf63...00ff0f7. Read the comment docs.

@Manny91
Copy link
Author

Manny91 commented Mar 17, 2017

@valorkin Hello! can you check if it's good to merge?

@maximelafarie
Copy link

maximelafarie commented May 10, 2017

@valorkin urgent PR as mentioned in #680 !

@Manny91
Copy link
Author

Manny91 commented May 11, 2017

@maximelafarie indeed! will be nice to get it merged but, still haven't got any response from @valorkin

@khylias
Copy link

khylias commented May 15, 2017

👍

@varrob112
Copy link

Merge this pls... @valorkin

@maximelafarie
Copy link

maximelafarie commented Jun 26, 2017

@varrob112 Awaiting @valorkin merge it (and if it's urgent for you), you can do it your own as I done here : https://github.com/maximelafarie/ng2-select. You just need to merge the @Manny91 PR branch in the main and you're done 😉

@GiantFlash
Copy link

Merge this pls... @valorkin

@DoanVanThuong
Copy link

is it resolved? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants