fix: Make .changed property optional in JupyterChart #3868
#3871
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azjps
changed the title
.changed property optional in JupyterChart #3868
azjps
changed the title
.changed property optional in JupyterChart #3868.changed property optional in JupyterChart #3868
|
Thanks for submitting a fix for the issue you reported earlier @azjps ! @jonmmease Do you have the bandwidth to review if this change makes sense? |
value.changed is an implementation detail in Jupyter's backbone.js patch, and isn't supported in other AFM implementations such as marimo's (or streamlit, nicegui, etc). To silence the errors and allow updates from python to JS happen, for now signaling all params instead of just changed ones, if .changed is undefined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to #3868 for details.
value.changedis an implementation detail in Jupyter's backbone.js patch, and isn't supported in other AFM implementations such as marimo's (or streamlit, nicegui, etc).To silence the errors and allow updates from python to JS happen, for now signaling all params instead of just changed ones, if
.changedis undefined.