Skip to content

Adding CURRENT_WATERMARK recipe #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 5, 2021
Merged

Adding CURRENT_WATERMARK recipe #47

merged 2 commits into from
Oct 5, 2021

Conversation

MartijnVisser
Copy link
Contributor

  • Added a new recipe for CURRENT_WATERMARK

@MartijnVisser MartijnVisser requested a review from knaufk October 1, 2021 10:35
knaufk
knaufk suggested changes Oct 1, 2021
View reviewed changes
Copy link
Contributor

@knaufk knaufk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MartijnVisser. Very important recipe! I left a few comments.

@MartijnVisser
Copy link
Contributor Author

Thanks for the reviews @infoverload @knaufk
I've addressed all of them. Let me know what you think

knaufk
knaufk approved these changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@knaufk knaufk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for addressing the comments.

I left one comment for consideration.

@MartijnVisser MartijnVisser merged commit 98c34a5 into ververica:main Oct 5, 2021
@MartijnVisser MartijnVisser deleted the current_watermark branch October 5, 2021 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@infoverload infoverload Awaiting requested review from infoverload

1 more reviewer

@knaufk knaufk knaufk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MartijnVisser @infoverload @knaufk