-
Notifications
You must be signed in to change notification settings - Fork 209
Recipe: Expanding arrays into new rows #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
62eed29
to
192dd51
Compare
192dd51
to
edf0be5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MartijnVisser. UNNEST is a good topic. IMO the example is unnecessarily complex to highlight the build-in function, at least I hard a time getting it.
other-builtin-functions/05_exploding_arrays/05_exploding_arrays.md
Outdated
Show resolved
Hide resolved
other-builtin-functions/05_exploding_arrays/05_exploding_arrays.md
Outdated
Show resolved
Hide resolved
edf0be5
to
d58819a
Compare
@knaufk I've simplified the recipe by removing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Looks good voerall. A few more minor suggestions.
other-builtin-functions/05_exploding_arrays/05_exploding_arrays.md
Outdated
Show resolved
Hide resolved
other-builtin-functions/05_exploding_arrays/05_exploding_arrays.md
Outdated
Show resolved
Hide resolved
other-builtin-functions/05_exploding_arrays/05_exploding_arrays.md
Outdated
Show resolved
Hide resolved
d58819a
to
1338c15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment. Otherwise LGTM.
1338c15
to
04fe330
Compare
No description provided.