Skip to content

Conversation

folortin
Copy link
Contributor

The value of EPSILON was changed from 0.001 to 1 to avoid unnecessary overlaps and prevent element overflow during collision detection.

… overlaps and prevent element overflow during collision detection.

The value of EPSILON was changed from 0.001 to 1 to avoid unnecessary overlaps and prevent element overflow during collision detection.
Copy link
Member

@Thomaash Thomaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide any evidence and ideally tests for this? The idea was to avoid rounding errors. Increasing it by 3 orders of magnitude doesn't feel right without any concrete data to justify it. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants