Skip to content

Conversation

mgoin
Copy link
Member

@mgoin mgoin commented Oct 14, 2025

Purpose

The nm-testing/TinyLlama-1.1B-Chat-v1.0-FP8-e2e model was modified and is failing these tests in the Blackwell runner with

  Value error, Invalid repository ID or local directory specified: 'nm-testing/TinyLlama-1.1B-Chat-v1.0-FP8-e2e'.

https://buildkite.com/vllm/ci/builds/34753/steps/canvas?sid=0199e0e1-07c3-4e2f-8932-18a67f8f1ed7

We can replace this model with a more stable base

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@mergify mergify bot added the llama Related to Llama models label Oct 14, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a CI failure by replacing a missing Hugging Face model reference with a valid one in three test files. The change is correct and addresses the issue. I've added comments to update the misleading comments in the code that describe how the model name is used. I also recommend centralizing the hardcoded model name into a constant in a follow-up PR to improve maintainability, as it's currently duplicated across multiple files.

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 14, 2025
@mgoin mgoin added the ci-failure Issue about an unexpected test failure in CI label Oct 14, 2025
@DarkLight1337 DarkLight1337 merged commit c3a722f into vllm-project:main Oct 14, 2025
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-failure Issue about an unexpected test failure in CI llama Related to Llama models ready ONLY add when PR is ready to merge/full CI is needed

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants