-
Notifications
You must be signed in to change notification settings - Fork 7
Adding new Rendering and Specialized accessibilityFeature Examples #731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
using timed test which matches defintion
removed redundant note.
@mattgarrish All your improvements have been included as well as adding two missing "annotations" and "unlocked" |
<h4>Structure and navigation terms</h4> | ||
|
||
<section id="metadata-a11y-features-annotations"> | ||
<h5>Annotations</h5> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weren't we just discussing deprecating this value, though? I thought the argument against it was that the annotations are generally for all readers and rarely address a specific accessibility need.
Yeah, not sure if we finalized that or not. I can add a note here saying we may deprecate this.
Ummm if we deprecate it I probably would then just delete it just like "bookmarks" and "captions" or do you think it should go into the "unsupported" section and I should add "bookmarks" and "captions" there and say why they are unsupported ie. depricated or replaced by open/closeCaptions.
What do you think?
|
No, we talked about it but I think it was left to us to take up in the schema.org vocabulary document. I just want to make sure I'm remembering that right. @madeleinerothberg @avneeshsingh does that match your thinking on this value? It might be good to remove the section and I'll open a pull request in the other repository to mark the property as deprecated. |
used correct mathvarient="normal" and removed empty mrow's. Thanks Neil S.
@mattgarrish Ok I think we are ready for the final review here before merging all the features. |
Hi @mattgarrish @gregoriopellegrino @GeorgeKerscher Here is a link to the rendered view of the PR.[1] [1] https://raw.githack.com/w3c/publ-a11y/pull/731/head/epub-a11y-meta-guide/1.0/draft/index.html |
I did not go through each line of added code, but what I went through is looking good! |
No description provided.