support for in loop for class and interface #15
Conversation
Signed-off-by: zhenweijin <[email protected]>
Signed-off-by: zhenweijin <[email protected]>
| const vtable = binaryenCAPI._BinaryenStructGet( | ||
| module.ptr, | ||
| StructFieldIndex.VTABLE_INDEX, | ||
| obj, | ||
| binaryen.i32, | ||
| false, | ||
| ); | ||
| const metaValue = binaryenCAPI._BinaryenStructGet( | ||
| module.ptr, | ||
| VtableFieldIndex.META_INDEX, | ||
| vtable, | ||
| binaryen.i32, | ||
| false, | ||
| ); |
There was a problem hiding this comment.
I think "get vtable" and "get meta" should become two helper functions
Signed-off-by: zhenweijin <[email protected]>
| metaFiledsPtrIndex, | ||
| module.i32.add( | ||
| meta, | ||
| module.i32.const(MetaDataOffset.FILEDS_PTR_OFFSET), |
There was a problem hiding this comment.
| module.i32.const(MetaDataOffset.FILEDS_PTR_OFFSET), | |
| module.i32.const(MetaDataOffset.FIELDS_PTR_OFFSET), |
| // 3. get meta fields ptr | ||
| statementArray.push( | ||
| module.local.set( | ||
| metaFiledsPtrIndex, |
There was a problem hiding this comment.
| metaFiledsPtrIndex, | |
| metaFieldsPtrIndex, |
| } | ||
|
|
||
| export const enum MetaFieldOffset { | ||
| export const SIZE_OF_META_FIELD = 12; |
There was a problem hiding this comment.
What does this mean?
this means the size of bytes occupied by the meta field, it helps to traverse every meta field.
src/semantics/value.ts
Outdated
| CLOSURE_CALL, | ||
| CONSTRUCTOR_CALL, | ||
| ANY_CALL, | ||
| WASM_FUNCTION_CALL, |
There was a problem hiding this comment.
We can't introduce such concept in semantic tree, semantic tree should not be coupled with a specific backend.
src/expression.ts
Outdated
| /** it uses to specified a wasm function call in compile time, | ||
| * sometimes the wasm function maybe is not generated from a ts function | ||
| */ | ||
| export class CallWASMFunction extends Expression { |
There was a problem hiding this comment.
Also, we shouldn't introduce such concept in frontend, this is a special design in binaryen backend.
Signed-off-by: zhenweijin <[email protected]>
src/expression.ts
Outdated
| /** it uses to specified a wasm function call in compile time, | ||
| * sometimes the wasm function maybe is not generated from a ts function | ||
| */ |
There was a problem hiding this comment.
Should update the comment
| private obj: Expression; | ||
|
|
||
| constructor(obj: Expression) { | ||
| super(ts.SyntaxKind.PropertyAccessExpression); |
There was a problem hiding this comment.
Why we use PropertyAccessExpression here?
There was a problem hiding this comment.
In ts.SyntaxKind seems to lack an appropriate type to uniquely represent the access of enumerate keys. Therefore, here we use ts.SyntaxKind.PropertyAccessExpression to indicate obtaining the key attribute from an object.
There was a problem hiding this comment.
Got it, had better leave a comment here
There was a problem hiding this comment.
Would it be better to use SyntaxKind.Unknown to indicate this is a customized node?
There was a problem hiding this comment.
I don't think it's very suitable, because SyntaxKind.Unknown has its own meaning in the frontend, it has already been used to represent some nodes that the compiler doesn't support or implement.
| expr as PropertyAccessExpression, | ||
| context, | ||
| ); | ||
| if (expr instanceof EnumerateKeysExpression) { |
There was a problem hiding this comment.
Had better also leave a comment here
Signed-off-by: zhenweijin <[email protected]>
2 participants
No description provided.