fix: the 'belongedClass' property of the overridden method has been tampered with #21
Conversation
|
Currently, the ‘belongedClass‘ property is mostly used in the specialization logic of the constructor of a generic class. |
Shanks0224
changed the title
src/type.ts
Outdated
| addMethod(classMethod: TsClassFunc): void { | ||
| classMethod.type.isMethod = true; | ||
| classMethod.type.belongedClass = this; | ||
| // the subclass inherits the method of the base class and should not modify the belongedClass of the base class method. |
There was a problem hiding this comment.
| // the subclass inherits the method of the base class and should not modify the belongedClass of the base class method. | |
| // when sub class inherits the method of the base class, it should not modify the `belongedClass`. |
| infc.addMethod(method); | ||
| infc.addMethod({ | ||
| name: method.name, | ||
| type: method.type.clone(), |
There was a problem hiding this comment.
why here use a copy type of method?
There was a problem hiding this comment.
If copy is not used, the method inherited from the base class in the subclass represents the same object as the base class method.
When modifying the property value of a method in a subclass, it will affect the method of the base class.
…ampered with its subclass Signed-off-by: ganjing <[email protected]>
Shanks0224
force-pushed
the
dev_ganjing
branch
from
774f832 to
823a743
Compare
3 participants
When the method of the base class is overridden, the 'belongingClass' property of this method is tampered with into its subclass.