Merge pull request kbsali#117 from gpilla/master

Added support for downloading attachments

Author: kbsali

example.php

@@ -213,6 +213,9 @@
 // Attachments
 $client->api('attachment')->show($attachmentId);
 
+$file_content = $client->api('attachment')->download($attachmentId);
+file_put_contents('example.png', $file_content);
+
 // ----------------------------
 // News
 $client->api('news')->all('test');

lib/Redmine/Api/AbstractApi.php

@@ -44,9 +44,9 @@ public function lastCallFailed()
      *
      * @return array
      */
-    protected function get($path)
+    protected function get($path, $decode = true)
     {
-        return $this->client->get($path);
+        return $this->client->get($path, $decode);
     }
 
     /**

lib/Redmine/Api/Attachment.php

@@ -22,6 +22,17 @@ public function show($id)
         return $this->get('/attachments/'.urlencode($id).'.json');
     }
 
+    /**
+     * Get attachment content as a binary file
+     *
+     * @param  string $id the attachment number
+     * @return string the attachment content
+     */
+    public function download($id)
+    {
+        return $this->get('/attachments/'.urlencode($id), false);
+    }
+
     /**
      * Upload a file to redmine
      * @link http://www.redmine.org/projects/redmine/wiki/Rest_api#Attaching-files

lib/Redmine/Client.php

@@ -146,15 +146,20 @@ public function getUrl()
 
     /**
      * HTTP GETs a json $path and tries to decode it
-     * @param  string $path
+     * @param  string  $path
+     * @param  boolean $decode
      * @return array
      */
-    public function get($path)
+    public function get($path, $decode = true)
     {
         if (false === $json = $this->runRequest($path, 'GET')) {
             return false;
         }
 
+        if (!$decode) {
+            return $json;
+        }
+
         return $this->decode($json);
     }
 

lib/Redmine/TestUrlClient.php

@@ -4,7 +4,7 @@
 
 class TestUrlClient extends Client
 {
-    public function get($path)
+    public function get($path, $decode = true)
     {
         return $this->runRequest($path, 'GET');
     }