Skip to content

Conversation

@pull
Copy link

@pull pull bot commented Nov 9, 2023

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

@pull pull bot added the ⤵️ pull label Nov 9, 2023
lynch1981 and others added 28 commits November 12, 2023 22:10
Can be reproduced in valgrind mode in t/129-ssl-socket.t:

==55579== 13 bytes in 1 blocks are definitely lost in loss record 3 of 19
==55579==    at 0x483A809: malloc (vg_replace_malloc.c:307)
==55579==    by 0x44F522: ngx_alloc (ngx_alloc.c:22)
==55579==    by 0x549DDD: ngx_http_lua_ffi_socket_tcp_sslhandshake (ngx_http_lua_socket_tcp.c:1828)
==55579==    by 0x4897FEA: lj_vm_ffi_call (in /opt/luajit21/lib/libluajit-5.1.so.2.1.1700206165)
==55579==    by 0x48F7980: lj_ccall_func (lj_ccall.c:1402)
==55579==    by 0x4910E74: lj_cf_ffi_meta___call (lib_ffi.c:230)
==55579==    by 0x4895B7D: lj_BC_FUNCC (in /opt/luajit21/lib/libluajit-5.1.so.2.1.1700206165)
==55579==    by 0x5360E6: ngx_http_lua_run_thread (ngx_http_lua_util.c:1184)
==55579==    by 0x54203E: ngx_http_lua_socket_tcp_resume_helper (ngx_http_lua_socket_tcp.c:6207)
==55579==    by 0x542123: ngx_http_lua_socket_tcp_conn_resume (ngx_http_lua_socket_tcp.c:6113)
==55579==    by 0x5393B1: ngx_http_lua_content_wev_handler (ngx_http_lua_contentby.c:152)
==55579==    by 0x54014B: ngx_http_lua_socket_handle_conn_success (ngx_http_lua_socket_tcp.c:3638)
==55579==    by 0x54504E: ngx_http_lua_socket_connected_handler (ngx_http_lua_socket_tcp.c:3906)
==55579==    by 0x5405A7: ngx_http_lua_socket_tcp_handler (ngx_http_lua_socket_tcp.c:3426)
==55579==    by 0x4567C0: ngx_epoll_process_events (ngx_epoll_module.c:930)
==55579==    by 0x44AAB3: ngx_process_events_and_timers (ngx_event.c:258)
==55579==    by 0x454623: ngx_worker_process_cycle (ngx_process_cycle.c:793)
==55579==    by 0x45295B: ngx_spawn_process (ngx_process.c:199)
==55579==    by 0x45340E: ngx_start_worker_processes (ngx_process_cycle.c:382)
==55579==    by 0x4551F1: ngx_master_process_cycle (ngx_process_cycle.c:241)
==55579==    by 0x429DD6: main (nginx.c:387)
    This memory corruption will cause nginx crash and can reproduce under
    "--with-no-pool-patch" build by running t/048-match-dfa.t TEST 9.

    test log:
    ok 1 - t/048-match-dfa.t TEST 9: multiple match calls with captures and DFA. - status code ok
    ok 2 - t/048-match-dfa.t TEST 9: multiple match calls with captures and DFA. - response_body - response is expected (repeated req 0, req 0)
    t/048-match-dfa.t TEST 9: multiple match calls with captures and DFA. - Can't connect to 127.0.0.1:1984: Connection refused
            Retry connecting after 0.675 sec
    t/048-match-dfa.t TEST 9: multiple match calls with captures and DFA. - Can't connect to 127.0.0.1:1984: Connection refused
            Retry connecting after 0.825 sec

    error.log
    [notice] 1683757#0: using the "epoll" event method
    [notice] 1683757#0: openresty/1.25.3.1 (no pool)
    [notice] 1683757#0: built by gcc 13.2.1 20231011 (Red Hat 13.2.1-4) (GCC)
    [notice] 1683757#0: OS: Linux 6.7.4-100.fc38.x86_64
    [notice] 1683757#0: getrlimit(RLIMIT_NOFILE): 1024:524288
    free(): invalid next size (fast)

Co-author-by: lijunlong<[email protected]>
zhuizhuhaomeng and others added 30 commits July 23, 2025 21:43
so we need to change nginx_version value to 1029001 here
Co-authored-by: lijunlong <[email protected]>
Commit freenginx/nginx@3329aa9 updated the ngx_http_request_t
structure with the start_time; the start_sec and start_msec
were removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.