Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ libraryDependencies ++=
"junit" % "junit" % "4.13.2" % "test",
"org.codehaus.plexus" % "plexus-classworlds" % "2.9.0" % "test",
"org.xerial.java" % "xerial-core" % "2.1" % "test",
"org.wvlet.airframe" %% "airframe-log" % "2025.1.19" % "test",
"org.wvlet.airframe" %% "airframe-log" % "2025.1.21" % "test",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For improved maintainability, consider defining dependency versions in val definitions. This practice centralizes version management, making it easier to track and update dependencies consistently across the project.

For example:

val airframeVersion = "2025.1.21"

libraryDependencies ++= Seq(
  // ...
  "org.wvlet.airframe" %% "airframe-log" % airframeVersion % "test"
)

This is a suggestion for future improvement and not a blocker for this PR.

"org.osgi" % "org.osgi.core" % "6.0.0" % "provided",
"com.github.sbt" % "junit-interface" % "0.13.3" % "test",
"org.apache.hadoop" % "hadoop-common" % "3.4.1" % "test" exclude
Expand Down
Loading