Support for Sequence and Node as a Node key in Go map
#59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go does not support slices or maps as a map key. But we can use fixed length arrays as map keys.
ccoVeille
reviewed
Jul 12, 2025
Comment on lines
+1042
to
+1047
| if v.IsNil() { | ||
| // Zero value for interface{} | ||
| return reflect.Zero(reflect.TypeOf((*interface{})(nil)).Elem()), nil | ||
| } else { | ||
| return makeComparableKey(v.Elem()) | ||
| } |
There was a problem hiding this comment.
Suggested change
| if v.IsNil() { | |
| // Zero value for interface{} | |
| return reflect.Zero(reflect.TypeOf((*interface{})(nil)).Elem()), nil | |
| } else { | |
| return makeComparableKey(v.Elem()) | |
| } | |
| if v.IsNil() { | |
| // Zero value for interface{} | |
| return reflect.Zero(reflect.TypeOf((*interface{})(nil)).Elem()), nil | |
| } | |
| return makeComparableKey(v.Elem()) |
| // type Entry struct { Key K; Value V } with K and V the original map’s key and value types. | ||
| // | ||
| // - Otherwise, it returns v unchanged (for primitives, structs, etc.). | ||
| func makeComparableKey(v reflect.Value) (reflect.Value, error) { |
There was a problem hiding this comment.
I read the code multiple times, and I feel like err is always nil. The code is recursive, but nothing return an error.
I might be wrong, but removing error from the signature if we don't need it would make the code way simpler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go does not support slices or maps as a map key.
But we can use fixed length arrays as map keys.