Fallback location regex confusion fix #11
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bpaste service switched to https-only and to using pinnwand on the back-end instead of lodge-it. This patch makes the necessary changes to wgetpaste, so that it can upload to bpaste.net again.
The poundpython paste service redirects http requests to https. However, the redirect strips the post data. This patch works around that problem by using the https URL directly. The function geturl() is also updated so that it returns at most one URL.
This reverts commit cc4f2d5.
The fallback location regex can get confused if the input data contains URLs, and the confusion will cause wgetpaste to print the wrong link to the paste. Updated the regex so it finds the last URL that contains the service URL. wgetpaste can still get confused after this commit, but this commit should reduce the likelihood. Signed-off-by: Nicholas Vinson <[email protected]>
Contributor
Author
|
Pull request wasn't properly generated. Will recreate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fallback location regex can get confused if the input data contains
URLs, and the confusion will cause wgetpaste to print the wrong link to
the paste.
Updated the regex so it finds the last URL that contains the service
URL. wgetpaste can still get confused after this commit, but this commit
should reduce the likelihood.
Fixes issue #10