Skip to content

Update use-transition.mdx #1781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2021
Merged

Update use-transition.mdx #1781

merged 1 commit into from
Dec 11, 2021

Conversation

david-buck
Copy link
Contributor

Update "Transitioning between routes" example to use latest React Router syntax

Why

React Router has changed a little since v5. This is to keep the docs up to date for people who are using the latest version of React Router.

What

Updated the use-transition example for animating routes to use React Router 6's updated syntax https://reactrouter.com/docs/en/v6/api#routes-and-route

Checklist

  • [ x ] Documentation updated
  • [ x ] Ready to be merged

Update "Transitioning between routes" example to use latest React Router syntax
@vercel
Copy link

vercel bot commented Dec 9, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/react-spring-io/GGyejPjMNFjJZYjdenX8NvX8Hy7A
✅ Preview: https://react-spring-io-git-fork-david-buck-master-pmndrs.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 9, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cc35652:

Sandbox Source
spring-card Configuration
pmndrs/react-spring Configuration
spring-flip-card Configuration
spring-slide Configuration
spring-draggable-list Configuration
pmndrs/react-spring Configuration
spring-viewpager Configuration
pmndrs/react-spring Configuration
spring-image-fade Configuration
pmndrs/react-spring Configuration
spring-masonry Configuration
spring-animating-auto Configuration
spring-multistage-transition Configuration
pmndrs/react-spring Configuration
pmndrs/react-spring Configuration
spring-css-keyframes Configuration
spring-notification-hub Configuration
initial-rocket Configuration
spring-notification-hub Configuration
spring-notification-hub Configuration

Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! thank you for the contribution ⭐

@joshuaellis joshuaellis merged commit 267705d into pmndrs:master Dec 11, 2021
joshuaellis added a commit that referenced this pull request Dec 16, 2021
* chore(docs): update use-transition.mdx (#1781)

Update "Transitioning between routes" example to use latest React Router syntax

* chore(docs): update readme to use the right rafz (#1780)

Co-authored-by: Josh <[email protected]>

* fix: stop rafz update loop if there are no updates scheduled

* fix: move count out of tree-shakable state because we're reading it in non-tests now

* fix: fixes types in test

* docs: fix typo (correspend -> correspond) (#1789)

* chore: rename isStarted to isRunning

Co-authored-by: David Buck <[email protected]>
Co-authored-by: Franco Arza <[email protected]>
Co-authored-by: Josh <[email protected]>
Co-authored-by: Florian Kissling <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants