Add support for LDAP tls #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I haven't yet have a chance to test it. When I would test it on my setup I would mark this PR as ready |
Contributor
Author
|
I just realised that I wouldn't be able to test it. |
Collaborator
|
@dm3ch thanks for opening this up! I'll setup a local environment and test it to make sure it works |
primetheus
reviewed
Apr 8, 2023
Co-authored-by: Jared Murrell <[email protected]>
|
hey @primetheus, do mind giving this a re-review? if you want help testing on a local environment, I wouldn't mind helping you out with that. |
Collaborator
|
yes, apologies for the late reply. I'll have this wrapped up tonight! |
primetheus
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/fix #150