forked from wix-incubator/react-native-controllers
-
Notifications
You must be signed in to change notification settings - Fork 0
Update with wix's code #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…above the whole app.
…e's a slide animation with spring also some minor refactoring
…nts react-native from getting touch events on the left screen area that the gesture handles. Overriding the delegate of the gesture prevents this from happening while keeping the gesture intact.
* RCCNotification: merge from master if necessary, add a view with the same color to cover the gap if there's a slide animation with spring also some minor refactoring added simple animation preset support showing a bottom notification added auto-resizing mask to support rotation ( added autoresizing-mask (support rotation) initial commit: implement a top notification view which is displayed above the whole app. # Conflicts: # ios/RCCViewController.h # ios/ReactNativeControllers.xcodeproj/project.pbxproj
added launchOptions to RCCManager
…ootView in case the root was replaced while a modal was presented. Commit 1e48603 already fixed the same issue somehow but it didn't make sense, the actual problem was not waiting for the modal dismiss to occur.
feat(tab item): set accessibilityIdentifier property for e2e tests
…h (like pressing on buttons or list items) won't be executed when pan is done (issue #18)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.