Skip to content

Update with wix's code #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Aug 31, 2016
Merged

Conversation

simonmitchell
Copy link

No description provided.

artald and others added 29 commits May 25, 2016 23:27
…e's a slide animation with spring

also some minor refactoring
…nts react-native from getting touch events on the left screen area that the gesture handles.

Overriding the delegate of the gesture prevents this from happening while keeping the gesture intact.
* RCCNotification:
  merge from master
  if necessary, add a view with the same color to cover the gap if there's a slide animation with spring also some minor refactoring
  added simple animation preset
  support showing a bottom notification
  added auto-resizing mask to support rotation (
  added autoresizing-mask (support rotation)
  initial commit: implement a top notification view which is displayed above the whole app.

# Conflicts:
#	ios/RCCViewController.h
#	ios/ReactNativeControllers.xcodeproj/project.pbxproj
added launchOptions to RCCManager
…ootView in case the root was replaced while a modal was presented.

Commit 1e48603 already fixed the same issue somehow but it didn't make sense, the actual problem was not waiting for the modal dismiss to occur.
feat(tab item): set accessibilityIdentifier property for e2e tests
	- a timing issue with RN now requires us to wait until the bridge finishes loading before we can create the RCTRootViews
	- also added the missing import for objc runtime.

related to issue #85 and PR #86
…h (like pressing on buttons or list items) won't be executed when pan is done (issue #18)
@simonmitchell simonmitchell merged commit 1ae39c9 into 3sidedcube:master Aug 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants