-
Notifications
You must be signed in to change notification settings - Fork 0
Kmp 2to3 fixes poetry (C4-1106) #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ion declaration lives.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good should be tested in CGAP though
.github/workflows/main-publish.yml
Outdated
# This workflow contains a single job called "build" | ||
build: | ||
# The type of runner that the job will run on | ||
runs-on: ubuntu-20.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
22.04?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Fixed.
.github/workflows/main.yml
Outdated
name: Python ${{ matrix.python_version }} Tests | ||
|
||
# The type of runner that the job will run on | ||
runs-on: ubuntu-20.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
22.04?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, too.
.github/workflows/main.yml
Outdated
runs-on: ubuntu-20.04 | ||
strategy: | ||
matrix: | ||
python_version: ['3.7', '3.8', '3.9', '3.10', '3.11'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for 3.7 I'd say
setup.py
Outdated
@@ -1,26 +1,31 @@ | |||
import glob |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file can be deleted entirely no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seemingly. It took some adjusting but seems to be working now.
version.py
Outdated
@@ -0,0 +1 @@ | |||
vcf/__init__.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be deleted no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to reimplement how it __init__.py
gets the version, but yeah, I don't think version.py
is doing anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my revised version, it gets the VERSION from pyproject.toml
(indirectly through importlib.metadata
) whereas previously __init__.py
was the source of authority on version.
…minate 3.7 support. Adjust workflows for testing.
…sion differently.
This tested cleanly in cgap-portal testing for Python 3.8 on my local machine.
Also in Python 3.11 on GA. |
OK, I've moved the label to 3.0.0 since, by agreement with @willronchetti on Slack, passing tests in |
This adds poetry, PEP8, and some fixes to the tests and the repo.