Release v3.2.0 #2015

dasanra · 2021-03-10T10:43:28Z

Added

Allow to connect using WalletConnect on Energy Web Chain network ( Enable WalletConnect on EWC #1918 )
Allow off-chain signatures for Safes using v1.0.0 smart contract ( Allow off-chain signatures for pre 1.1.1 Safes #1645 )
Rejections use safeTxGas = 0 ( Set safeTxGas=0 for rejections #1978 )
Use client gateway to fetch token balances ( v1 Fetch assets from client gateway #1801 )

Fixed

Show correct Safe policies when removing an owner ( Deleting owner is not updating policies in the review step #1977 )
Fix gas estimation message and send gasLimit estimation to Metamask when creating a new safe ( (Feature) Estimate gas for safe creation #1825 )
Address copy to clipboard also emit a submit in Send Modal ( The "Copy to clipboard" button is working as a submit button in the modals #1976 )
Infinite spinner in transactions view for new created safe ( Spinner does not disappear on Queue for new created safe #1906 )
Display transaction fee based in gasLimit ( Displayed tx fee wrong #1885 )
Fixed manifest check for Safe Apps ( Can only add Safe apps with an INVALID manifest #1899 )
Fixed only execution step for transactions with safeTxGas = 0 ( Gas limit is set to 21k for the cancellation tx on web if the cancellation tx was created and got last required confirmation on mobile #1970 On-chain cancellations with safeTxGas=0 are marked as "most likely to fail" #1975 )

Chore

Improvements in modals styles and wording ( (feature) Wording and styles improvements in modals #1974 )
Improve text when fiat value is 0 ( Misleading text when fiat value is 0 #1629 )
Cleanup old transaction list unused code ( [Chore] Cleanup old tx list leftovers #1996 )
Upgrade dependencies ( Upgrade dependencies #2009 )

…opment

Mergeback release v3.1.0 to development

* Types in safeDataExtractor.ts * Adds useEstimateSafeCreationGas hook * Refactor Layout.tsx * Remove gas price in estimateGasForDeployingSafe * Types in createSafe and adds gasLimit to deployment transaction * Uses useEstimateSafeCreationGas in ReviewComponent for transaction creation * Add types * Fix types * Fix types of ReviewInformation modal on safe load * Fix safe creation for multiple owners * fix unit tests * Remove unnecesary minimum tx gas Co-authored-by: Mati Dastugue <[email protected]> Co-authored-by: nicolas <[email protected]> Co-authored-by: nicosampler <[email protected]> Co-authored-by: Daniel Sanchez <[email protected]>

Mergeback CI fixes to development

* Enable Wallet connect on EWC

…opment

* set owners and threshold properly * Take threshold from step 2

…" (#2002) This reverts commit 0fb02c7.

* Cleanup old transaction list files * Rename view folder from GatewayTransactions to TxList * Remove all reducer logic for incomingTransactions * Delete allTransactionsLogic * Cleanup cancel transaction legacy logic * Remove fetch creation transaction * Remove moduleTransactions logic * Remove unused transfer methods * Cleanup unused types

* Replace collectibles fetch with client gateway * Replaces balance endpoint with client gateway * Remove default export of tokens list * Set the default rows per page to 100 * Fix ether price load * Remove Add custom token button * Remove add custom asset and add custom token modals

* add external icon in safe version (settings) * change wording in receive modal * fix Modal titles and color on back/cancel button * move toggle to the left (contract interaction modal) * add title "Method" for drop down * review lettercase in titles and buttons * add contract address label in contract interaction * fix label for input "Contract address" * fix label when use custom data (Contract address) * fix external link component on Safe version * change Label "Recipient" to "Contract address"

* Upgrade dependencies without breaking changes * Remove travis leftovers * Upgrade types dependencies * Upgrade eslint rules to new prettier configuration

* Rename custom transaction to custom interaction * fix no transaction img size

Co-authored-by: Daniel Sanchez <[email protected]>

* remove url as required attribute of manifest.json for safe-apps * getAppInfoFromUrl: get requiredData from manifest

github-actions · 2021-03-10T10:43:42Z

CLA Assistant Lite All Contributors have signed the CLA.

github-actions · 2021-03-10T10:48:59Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	14	0
Ignored	10	N/A

Result: ✅ success
Annotations: 14 total

[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods

src/logic/safe/store/middleware/notificationsMiddleware.ts Line 65 - Argument 'store' should be typed.
src/logic/safe/store/middleware/notificationsMiddleware.ts Line 65 - Argument 'next' should be typed.
src/logic/safe/store/middleware/notificationsMiddleware.ts Line 65 - Missing return type on function.
src/logic/safe/store/middleware/notificationsMiddleware.ts Line 65 - Argument 'action' should be typed.
src/logic/safe/transactions/offchainSigner/index.ts Line 22 - Argument 'txArgs' should be typed.
src/logic/wallets/store/actions/fetchProvider.ts Line 12 - Missing return type on function.
src/logic/wallets/store/actions/fetchProvider.ts Line 12 - Argument 'dispatch' should be typed.
src/logic/wallets/store/actions/fetchProvider.ts Line 12 - Argument 'provider' should be typed.
src/routes/open/components/fields.ts Line 10 - Missing return type on function.
src/routes/open/components/fields.ts Line 10 - Argument 'values' should be typed.
src/routes/safe/components/Balances/SendModal/screens/ContractInteraction/Buttons/index.tsx Line 16 - Missing return type on function.
src/routes/safe/components/Transactions/TxList/SpendingLimitDetails.tsx Line 15 - Missing return type on function.
src/routes/safe/components/Transactions/TxList/SpendingLimitDetails.tsx Line 16 - Missing return type on function.
src/routes/safe/components/Transactions/TxList/SpendingLimitDetails.tsx Line 17 - Missing return type on function.

^{Report generated by eslint-plus-action}

github-actions · 2021-03-10T10:53:52Z

Safe Multisig app rinkeby

github-actions · 2021-03-10T10:55:09Z

Safe Multisig app volta

github-actions · 2021-03-10T10:56:39Z

Safe Multisig app xdai

…2013)

francovenica · 2021-03-10T18:56:02Z

github-actions · 2021-03-10T19:01:15Z

Safe Multisig app xdai

github-actions · 2021-03-10T19:03:44Z

Safe Multisig app volta

github-actions · 2021-03-10T19:04:00Z

Safe Multisig app rinkeby

github-actions · 2021-03-11T09:46:48Z

Safe Multisig app rinkeby

github-actions · 2021-03-11T09:47:44Z

Safe Multisig app volta

github-actions · 2021-03-11T09:48:23Z

Safe Multisig app xdai

github-actions · 2021-03-11T09:53:00Z

Safe Multisig app xdai

github-actions · 2021-03-11T09:54:57Z

Safe Multisig app rinkeby

github-actions · 2021-03-11T09:56:29Z

Safe Multisig app volta

francovenica · 2021-03-11T19:11:32Z

Issues NFT's:

The NFT's are still showing in the list after a transfer, even when they already are showing in the recipient safe where they were sent
It has been over 20 mins since the tx was executed at the moment of writing this

Safe sent from: https://pr2015--safereact.review.gnosisdev.com/rinkeby/app/#/safes/0xfB9d4e27aA63f51DeE7c644e82d49D60AC975838/balances

Safe that received it:
https://pr2015--safereact.review.gnosisdev.com/rinkeby/app/#/safes/0x9913B9180C20C6b0F21B6480c84422F6ebc4B808/balances

The tx:
https://rinkeby.etherscan.io/tx/0xc7e318fdf58cf249ebe4133b4567546fccd9a094119a47249d23ddb84475baff

Question:
We made that safes 1.0.0 can see NFT's? I don't remember that being a thing.
This safe 1.0.0 has one
https://pr2015--safereact.review.gnosisdev.com/rinkeby/app/#/safes/0xeca13481F8514752dC08106c7A265c85caFa563E/balances/collectibles

francovenica · 2021-03-11T20:22:40Z

Update: The token is not longer showing in the safe where it was transferred from. Is weird that it took more than 30 minutes to disappear

github-actions · 2021-03-12T08:41:45Z

Safe Multisig app volta

github-actions · 2021-03-12T08:42:00Z

Safe Multisig app rinkeby

github-actions · 2021-03-12T08:42:21Z

Safe Multisig app xdai

francovenica

Looks good enough for Staging

matextrem and others added 27 commits February 23, 2021 19:25

Merge branch 'development' of github.com:gnosis/safe-react into devel…

059fa5d

…opment

Merge branch 'development' of github.com:gnosis/safe-react into devel…

5e1f380

…opment

Merge pull request #1985 from gnosis/release/v3.1.0

a2bbbf4

Mergeback release v3.1.0 to development

Merge branch 'development' into fix/v3.1.1

883e6f4

Merge pull request #1988 from gnosis/fix/v3.1.1

3c0f9a1

Mergeback CI fixes to development

[EWC] Enable Wallet connect (#1952)

a9f1130

* Enable Wallet connect on EWC

Merge branch 'development' of github.com:gnosis/safe-react into devel…

567de80

…opment

Bump safe components version with copy to clipboard fix

4fb7729

Set owners and threshold properly (#1979)

92a5f7d

* set owners and threshold properly * Take threshold from step 2

Merge branch 'development' into fix/copyToClipboard

ecde42f

Merge pull request #1995 from gnosis/fix/copyToClipboard

d082ab4

Revert "Fix - Copy to clipboard button prevents submit" (#2001)

0fb02c7

Revert "Revert "Fix - Copy to clipboard button prevents submit" (#2001)…

760a2a2

…" (#2002) This reverts commit 0fb02c7.

Allow off-chain signing and collectibles with 1.0.0 safes (#1966)

f4f79f0

Handle 404 responses for txs queue and history (#1990)

4c37a2b

set gas to 0 when rejecting a tx. (#1993)

7312c99

Change no fiat value text (#2006)

cb16192

Upgrade dependencies (#2009)

639bb98

* Upgrade dependencies without breaking changes * Remove travis leftovers * Upgrade types dependencies * Upgrade eslint rules to new prettier configuration

Fix: History and Queue pagination (#2003)

5ded9ee

Tx list v2 - design/wording follow ups (#1969)

4ee5fe5

* Rename custom transaction to custom interaction * fix no transaction img size

Set same estimation gasCost as MM (#2011)

6444c37

Co-authored-by: Daniel Sanchez <[email protected]>

remove url as required attribute of manifest.json for safe-apps (#1962)

5361aec

* remove url as required attribute of manifest.json for safe-apps * getAppInfoFromUrl: get requiredData from manifest

Fix load ga. (#1998)

b12e190

dasanra self-assigned this Mar 10, 2021

dasanra requested a review from francovenica March 10, 2021 10:56

Fix wrong estimation when only executing and selected safeTxGas is 0 (#…

26de414

…2013)

Daniel Sanchez and others added 2 commits March 11, 2021 10:35

Update transaction builder

cd2305f

remove rinkeby from supported networks for mushrooms finance app

77ce93a

Set v3.2.0

19eb4f6

francovenica approved these changes Mar 12, 2021

View reviewed changes

dasanra merged commit 99f4604 into master Mar 12, 2021

github-actions bot locked and limited conversation to collaborators Mar 12, 2021

Release v3.2.0 #2015

Release v3.2.0 #2015

Uh oh!

Conversation

dasanra commented Mar 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Added

Fixed

Chore

Uh oh!

github-actions bot commented Mar 10, 2021

Uh oh!

github-actions bot commented Mar 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ESLint Summary View Full Report

[warning] @typescript-eslint/explicit-module-boundary-types

Uh oh!

github-actions bot commented Mar 10, 2021

Uh oh!

github-actions bot commented Mar 10, 2021

Uh oh!

github-actions bot commented Mar 10, 2021

Uh oh!

francovenica commented Mar 10, 2021

Uh oh!

github-actions bot commented Mar 10, 2021

Uh oh!

github-actions bot commented Mar 10, 2021

Uh oh!

github-actions bot commented Mar 10, 2021

Uh oh!

github-actions bot commented Mar 11, 2021

Uh oh!

github-actions bot commented Mar 11, 2021

Uh oh!

github-actions bot commented Mar 11, 2021

Uh oh!

github-actions bot commented Mar 11, 2021

Uh oh!

github-actions bot commented Mar 11, 2021

Uh oh!

github-actions bot commented Mar 11, 2021

Uh oh!

francovenica commented Mar 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

francovenica commented Mar 11, 2021

Uh oh!

github-actions bot commented Mar 12, 2021

Uh oh!

github-actions bot commented Mar 12, 2021

Uh oh!

github-actions bot commented Mar 12, 2021

Uh oh!

francovenica left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

dasanra commented Mar 10, 2021 •

edited

Loading

github-actions bot commented Mar 10, 2021 •

edited

Loading

francovenica commented Mar 11, 2021 •

edited

Loading