task: Add serialize impl for ApiError #393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomharmon
force-pushed
the
task/add-serialize-for-api-error
branch
from
76393ee to
86d7fb6
Compare
- Adds the `serde::Serialize` derive macro to the `ApiError` type so that this error can be passed along the wire to clients for proxies
tomharmon
force-pushed
the
task/add-serialize-for-api-error
branch
from
86d7fb6 to
0a9e131
Compare
64bit
reviewed
Jun 29, 2025
64bit
reviewed
Jun 29, 2025
64bit
approved these changes
Jun 29, 2025
ifsheldon
pushed a commit
to ifsheldon/async-openai-wasm
that referenced
this pull request
Jun 29, 2025
* task: Add serialize impl for ApiError - Adds the `serde::Serialize` derive macro to the `ApiError` type so that this error can be passed along the wire to clients for proxies * Update async-openai/Cargo.toml * Update async-openai/Cargo.toml --------- Co-authored-by: Himanshu Neema <[email protected]> (cherry picked from commit 4b52f20)
jkoppel
pushed a commit
to up-to-speed/async-openai
that referenced
this pull request
Jul 8, 2025
* task: Add serialize impl for ApiError - Adds the `serde::Serialize` derive macro to the `ApiError` type so that this error can be passed along the wire to clients for proxies * Update async-openai/Cargo.toml * Update async-openai/Cargo.toml --------- Co-authored-by: Himanshu Neema <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! thanks for the great ilbrary! I would love to see if you'd be open to adding a
Serializeimpl to theApiErrortype so it can round trip.I also bumped the Cargo.toml version so a new crate version could be published, if you are able to do that after merging that would be awesome.
The diff in
async-openai/src/lib.rswas from runningcargo fmt