Rpm variable name change to 340 #352

gclough · 2018-04-26T10:12:53Z

A general tidy up of the install section, and some variable renames.

… support different providers.

…dded default verbose.

…rvices during boot instead of having extra tasks. I removed them since they are not necessary.

* Increse the travis test coverage to include popular options * Fixed a missing quote... * Fixed syntax for options, and make postgis.yml RedHat compatible... ish * Looks like pgtune won't install either, as the epel repo isn't in the docker image. Taking it out too.. * Changing parameters to be in JSON format, for consumption on the command line * Adding a space to trigger a travis build * Remove the space, as travis didn't build anyway... :-/ * Debugging... why don't travis kick in... * Revert travis changes, to try and get it to trigger * Fixed typo in JSON parameters * Removed travis updates, and put parameters into postgresql.yml * Squashing all commits. Increases travis coverage, but not all are enabled yet. Other pull requests need to be merged first, as the tests for them fail.

…", which I suspect is a more reliable method.

…earches

…ople find it on Galaxy

…}" instead of "{{var}""

…NXS#267) * Extended and adapted to install PostgreSQL 10 for CentOS and Ubuntu Tested with ansible 2.4.1 for Ubuntu 16.04 and CentOS-7.4 - replaced deprecated 'include:' by 'include_tasks:' for ansible 2.4.1 - added config and config template for postgresql 10 - adapted defaults.yml - adapted templates/etc_systemd_system_postgresql.service.d_custom.conf.j2 for PostgreSQL 10 the template outputs the wrong line: ExecStartPre=/usr/pgsql-10/bin/postgresql10-check-db-dir the correct one must include an additional '-': ExecStartPre=/usr/pgsql-10/bin/postgresql-10-check-db-dir * Removed tabs from defaults/main.yml. * Adapted .travis.yml and yml files to run tests successfully for all given ansible versions. - added a test for ansible 2.4.2.0/posgresql 10. - replaced newer 'include_task' by 'include' again so that the role can be used with older ansible versions. NOTE: 'include' is deprecated and will be removed in ansible 2.8. - commeted out docker based tests because they do not run successfully and I do not know docker ;-) * Bug fix. Removed remains for my local teste in test/playbook.yml. * Bug fix and refinement for postgresql.conf-10.* . - added max_parallel_workers to postgresql.conf-10.j2 (forgotten/deleted in previous version) - hard coded value for wal_retrieve_retry_interval in postgresql.conf-10.j2 replaced by ansible variable Changes to be committed: modified: Vagrantfile modified: defaults/main.yml modified: templates/postgresql.conf-10.j2 modified: vagrant-inventory * Added suggestions from gclough. Changes to be committed: modified: Vagrantfile modified: defaults/main.yml modified: templates/HOWTO.postgresql.conf modified: templates/etc_systemd_system_postgresql.service.d_custom.conf.j2 modified: tests/playbook.yml modified: tests/vars.yml modified: vagrant-inventory * Replaced vagrant setup by project's master branch. * Updated tests/docker/group_vars/all.yml to include version 10. * Uncommented 'no_log: true' in users.yml. * Uncommented user baz in tests/docker/group_vars/postgresql.yml. * Recreated user baz but without passwd. We need him as database owner :-). * Added encrypted passwd for user baz. * Commented need for encrypted password if version >= 10. * Reenabled no_log: true for task PostgreSQL | Make sure the PostgreSQL users are present Fixed text in templates/HOWTO.posgresql.conf * Just to trigger a new build on github. Added blank in README.md. * Second try to trigger a rebuild. Blank in README.md deleted.

* Adding future scope for v10 (already out), and v11 (Sep/18) * Fixed "CentOS" spelling, and put a request for help

…e less transactions

…ong night

ANXS#330) * Updated README to show v10 support, added top 10 contributors, and linked to defaults/main.yml * Fixed typo in contributors * Reload conf parameters after install, so that pg_hba.conf is re-read

… maintain it (ANXS#336)

Conflicts: handlers/main.yml tasks/extensions/postgis.yml tasks/install_yum.yml

Conflicts: tasks/extensions/dev_headers.yml

Conflicts: tasks/extensions/contrib.yml tasks/extensions/postgis.yml

gclough · 2018-04-26T10:35:55Z

@jlozadad , I've made some variable name changes that I proposed in the comments of #340, but I've also done a little tidy up of the install section, making changes to the recent Fedora support you added.

Can you see if this makes sense to you?

…variable_name_change_to_340 Conflicts: defaults/main.yml handlers/main.yml tasks/extensions/contrib.yml tasks/extensions/postgis.yml tasks/install.yml tasks/install_yum.yml tasks/main.yml

nissessenap · 2018-04-26T13:45:59Z

tasks/main.yml

  tags: [postgresql, postgresql-install]

 - import_tasks: install_yum.yml
  when: ansible_pkg_mgr == "yum" and ansible_distribution == "RedHat" 


Please add change to when: ansible_pkg_mgr == "yum" and ansible_distribution == "RedHat" or ansible_distribution == "CentOS"
or just: when: ansible_pkg_mgr == "yum"

@nissessenap, @gclough or change to ansible_os_family == 'RedHat'

nissessenap

The tasks/main.yml needs to be updated, this will fix the centos jobs.

…pm_variable_name_change_to_340

…ravis

gclough · 2018-04-26T14:12:22Z

@nissessenap , I never understood why the ansible_distribution was included, so I've removed them. All of the commands are apt/yum/dnf should work, as they test the package manager before including them.

aoyawale · 2018-04-26T14:41:55Z

the reason ansible_distribution was included so that it picks up fedora properly. If you use the regular os_family* it will show as red hat and run install_yum. adding those vars in the main.yml prevents them from being ran on both since fedora still uses yum.

aoyawale · 2018-04-26T15:00:01Z

tasks/extensions/postgis.yml

 - name: PostgreSQL | Extensions | Make sure the postgis extensions are installed | RedHat
  yum:
-    name: "{{ item }}"
+    name: "{{item}}"


why would you change it back this way? that is even worse.

aoyawale · 2018-04-26T15:03:34Z

tasks/main.yml

  tags: [postgresql, postgresql-install]

 - import_tasks: install_yum.yml
-  when: ansible_pkg_mgr == "yum" and ansible_distribution == "RedHat" 


the reason this was changed this way is that if you use os_family* for fedora it would come back as a red hat OS and run install_yum.yml besides the obvious failure of postgres 9.3 for fedora, travis build all of this successfully and worked for the vagrant files. I added pkg_mgr and distribution so it picks it up the correct one. if you leave pkg_mgr == "yum" it will run on fedora too.

OK, so I've put those back in, and included CentOS too as @nissessenap pointed out.

@gclough maybe better something like !(I dont remember right syntax for logical not) ansible_distribution == "Fedora"?

Or ansible_distribution != "Fedora"

I guess we can either take either approach:

We only support RedHat and CentOS... so let's list them explicitly

We want to be generic, so let's use a negative test

The current code uses option 1, but I'm happy enough to swap if that's the consensus. Would someone else like to do that, so spread the credit for this work?

(also, I can't seem to squash my commits without screwing everything up. I don't know why there are 43 commits in there!)

gclough · 2018-04-26T16:03:35Z

This should fix the current broken-build problem, but it does more than just fix that. I don't think there's a mega-rush to fix the build, but if this could be reviewed and merged soon-ish, then that would put us in a good place IMHO.

Thanks @nissessenap, @jlozadad , and @UnderGreen for your input and help thus far. If you're capable of squashing the commits and doing so under your account, that would be good so someone else get credit too, right?

aoyawale · 2018-04-26T16:20:05Z

looks like everything passed now.

Greg Clough and others added 30 commits April 3, 2018 23:58

Fixed wrong handler name

dbc66bc

change vagrantfile to point to the official centos images since those…

a931de8

… support different providers.

changed the vagrant file to use become since sudo is going away and a…

e1a9756

…dded default verbose.

changed install_yum.yml to use a block to reduce the transactions made.

11ef7ec

added retry files to gitignore.

435a284

added systemctl handler to restart when using OS that use systemctl.

d1799d8

changed to use the handlers to restart the services and enable the se…

6acef49

…rvices during boot instead of having extra tasks. I removed them since they are not necessary.

changed to check for systemd.

4a23ff7

Convert from using "psql" to using the Ansible module "postgresql_ext…

3ccfc9b

…", which I suspect is a more reliable method.

Added extra tests for travis to create extensions in "foobar" database

a785947

Added meta data for CentOS and RedHat, plus added tags to help with s…

abcfdd5

…earches

Fixed CenOS/RedHat naming... should be EL. Also added tags to help pe…

a220bc2

…ople find it on Galaxy

Quote all string variables, and add spaces around variables "{{ var }…

78daf4d

…}" instead of "{{var}""

Crosschecked, and found some that I missed.

97beb27

Octal numbers need to be quoted, otherwise they get converted to Decimal

a0cda0f

Prepare for PostgreSQL v10 (and v11) (ANXS#308)

2eadd1e

* Adding future scope for v10 (already out), and v11 (Sep/18) * Fixed "CentOS" spelling, and put a request for help

fixed the syntax on dev_headers

08273bb

added all the required dependencies together and deleted a tasks. Mak…

a35b232

…e less transactions

the other night when I started this. I forgot to add since it was a l…

8a81185

…ong night

accidently deleted vagrantfile

da29538

Reload conf parameters after install, so that pg_hba.conf is re-read

639a32b

Updated README to show v10 support, added top 10 contributors, and li… (

593c855

ANXS#330) * Updated README to show v10 support, added top 10 contributors, and linked to defaults/main.yml * Fixed typo in contributors * Reload conf parameters after install, so that pg_hba.conf is re-read

Fixed wrong handler name

172ace7

Added libselinux-python dependency for selinux enabled redhat systems.

a15fa3b

Honour those that created the role in the first place, and those that…

d4a27b3

… maintain it (ANXS#336)

Merge branch 'master' of https://github.com/ANXS/postgresql

d179625

Conflicts: handlers/main.yml tasks/extensions/postgis.yml tasks/install_yum.yml

Fixing local master

bb61157

More merging of master...

14579d6

Greg Clough added 4 commits April 24, 2018 17:23

Merge branch 'master' of https://github.com/ANXS/postgresql

a41228f

Merge branch 'master' of https://github.com/gclough/postgresql

8d57ef5

Conflicts: tasks/extensions/dev_headers.yml

Merge branch 'master' of https://github.com/ANXS/postgresql

8e296ed

Merge branch 'master' of https://github.com/gclough/postgresql

8887791

Conflicts: tasks/extensions/contrib.yml tasks/extensions/postgis.yml

gclough force-pushed the rpm_variable_name_change_to_340 branch 2 times, most recently from 7b246a4 to 19fa484 Compare April 26, 2018 10:29

gclough mentioned this pull request Apr 26, 2018

Removing duplicate postgresql_yum_repository_url_pgdg #350

Closed

gclough force-pushed the rpm_variable_name_change_to_340 branch from 41511b0 to 19e4924 Compare April 26, 2018 11:17

Tidied up variable and filenames for install_*.yml

695bed0

gclough force-pushed the rpm_variable_name_change_to_340 branch from 5b58852 to 695bed0 Compare April 26, 2018 11:32

Merge branch 'master' of https://github.com/ANXS/postgresql into rpm_…

c73d155

…variable_name_change_to_340 Conflicts: defaults/main.yml handlers/main.yml tasks/extensions/contrib.yml tasks/extensions/postgis.yml tasks/install.yml tasks/install_yum.yml tasks/main.yml

nissessenap reviewed Apr 26, 2018

View reviewed changes

nissessenap suggested changes Apr 26, 2018

View reviewed changes

Greg Clough added 4 commits April 26, 2018 14:54

Merge branch 'master' of https://github.com/gclough/postgresql into r…

4ac9a17

…pm_variable_name_change_to_340

Don't restrict apt/yum/dnf to specific OS types, and disable Fedora T…

33ed087

…ravis

Fixed merging problems

228a24b

Fixed mistake in comments

68a6e67

aoyawale reviewed Apr 26, 2018

View reviewed changes

Greg Clough added 2 commits April 26, 2018 16:32

Reinstate "ansible_distribution" tests

898ebcc

Removed extra "and"

ca4e111

gclough mentioned this pull request Apr 26, 2018

Disable Fedora testing, as PostgreSQL v9.3 doesn't exist #354

Merged

Removed duplicate 'name:' for dns repository

5a48cd2

UnderGreen merged commit 2e0349a into ANXS:master Apr 26, 2018

gclough deleted the rpm_variable_name_change_to_340 branch April 26, 2018 19:40

Rpm variable name change to 340 #352

Rpm variable name change to 340 #352

Uh oh!

Conversation

gclough commented Apr 26, 2018

Uh oh!

gclough commented Apr 26, 2018

Uh oh!

nissessenap Apr 26, 2018

Choose a reason for hiding this comment

Uh oh!

UnderGreen Apr 26, 2018

Choose a reason for hiding this comment

Uh oh!

nissessenap left a comment

Choose a reason for hiding this comment

Uh oh!

gclough commented Apr 26, 2018

Uh oh!

aoyawale commented Apr 26, 2018

Uh oh!

aoyawale Apr 26, 2018

Choose a reason for hiding this comment

Uh oh!

aoyawale Apr 26, 2018

Choose a reason for hiding this comment

Uh oh!

gclough Apr 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

UnderGreen Apr 26, 2018

Choose a reason for hiding this comment

Uh oh!

UnderGreen Apr 26, 2018

Choose a reason for hiding this comment

Uh oh!

gclough Apr 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gclough commented Apr 26, 2018

Uh oh!

aoyawale commented Apr 26, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gclough Apr 26, 2018 •

edited

Loading

gclough Apr 26, 2018 •

edited

Loading