Skip to content

scrollToFocusedInput flow types reflect how the arguments are used #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2018
Merged

scrollToFocusedInput flow types reflect how the arguments are used #207

merged 1 commit into from
Jan 12, 2018

Conversation

shichongrui
Copy link

extraHeight and keyboardOpeningTime are both optional arguments. reactNode should be any to match the type of scrollResponderScrollNativeHandleToKeyboard which is any. findNodeHandle is annotated as returning a number which causes the existing check of Object to fail.

Swordsman-Inaction
Swordsman-Inaction approved these changes Dec 22, 2017
View reviewed changes
Copy link
Collaborator

@Swordsman-Inaction Swordsman-Inaction left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@shichongrui
Copy link
Author

Thanks for the approval! Can this be merged and a new release cut?

@alvaromb alvaromb merged commit 96a0f3a into APSL:master Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swordsman-Inaction Swordsman-Inaction Swordsman-Inaction approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shichongrui @Swordsman-Inaction @alvaromb