fix enableAutoAutomaticScroll prop #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvaromb
requested changes
Jan 19, 2018
lib/KeyboardAwareHOC.js
Outdated
| if (this.props.viewIsInsideTabBar) { | ||
| keyboardSpace -= _KAM_DEFAULT_TAB_BAR_HEIGHT | ||
| } | ||
| this.setState({ keyboardSpace }) | ||
| // Automatically scroll to focused TextInput | ||
| if (this.props.enableAutoAutomaticScroll) { |
There was a problem hiding this comment.
Hey! Can you rename this prop to the intended name? It should be enableAutomaticScroll, not enableAutoAutomaticScroll (note the extra Auto). This has been an error I've introduced myself, but it would be great to change it with this PR.
|
LGTM 🚀 |
alvaromb
reviewed
Jan 19, 2018
lib/KeyboardAwareHOC.js
Outdated
| @@ -235,7 +234,7 @@ function listenToKeyboardEvents(ScrollableComponent: React$Component) { | |||
| ) { | |||
| this.scrollForExtraHeightOnAndroid( | |||
| totalExtraHeight - | |||
| (keyboardPosition - textInputBottomPosition) | |||
| (keyboardPosition - textInputBottomPosition) | |||
There was a problem hiding this comment.
Does this run prettier??
There was a problem hiding this comment.
woops, let me fix this haha
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request allows us to actually enable or disable the automatic scroll when focusing an input, as the prop was there but not working.