Skip to content

Addition of LR1110 driver #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Addition of LR1110 driver #234

wants to merge 11 commits into from

Conversation

kvkc97
Copy link

@kvkc97 kvkc97 commented Jun 29, 2021

The PR is to add LR1110 LoRa Driver for STM32WB55RG controller. The controller was added using custom target (MYTARGET) so as to include QSPI feature. The corresponding peripheral files for the custom target was added in TARGET_MYTARGET folder.

Modifications done for LR1110 driver.

  1. In mbed-os\connectivity\drivers\lora folder, a folder (COMPONENT_LR1110) was added with format similar to components SX1272 and SX1276. LR1110 specific files were modified for the same.
  2. Created CMakeLists file and mbed_lb.json file in the above mentioned folder for LR1110.
  3. Modified lora_radio_helper.h file from root folder to include a radio object for LR1110.
  4. Modified mbed_app.json in root folder to assign pin names to the LR1110 object parameters. (PinNames are given according to peripheral files)

Could you please review and suggest what went wrong. @0xc0170 @paul-szczepanek-arm @jeromecoutant @matthieuantoine

@paul-szczepanek-arm
Copy link
Member

Hi, this is showing 137,536 lines of changes and a conflicted file. If you're having trouble rebasing you can simply make a fresh checkout and re-apply your changes. Otherwise it's hard for others to see what you're doing.

@jeromecoutant
Copy link
Contributor

jeromecoutant commented Jul 1, 2021

yes, remove:

  • qspi addition in cpp file
  • TARGET_MY_TARGET directory
  • cmake_build directory

@kvkc97
Copy link
Author

kvkc97 commented Jul 1, 2021

Thanks for the suggestion. I have removed the mentioned files and updated the code. Also some changes was made in the mbed-os folder which could not be added to this repository. Therefore, I have created a separate repository for mbed-os library and made the changes. Attached is the link for the same.
https://github.com/kvkc97/mbed-os
The only change in mbed-os library is the addition of the COMPONENT_LR1110 folder at the location mbed-os\connectivity\drivers\lora

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 20, 2021

@kvkc97 would you be able to rebase , there should be linear history (no merge commits) as indicated in our guidelines

@kvkc97
Copy link
Author

kvkc97 commented Jul 21, 2021

I have created a new repo for he code with the latest mbed-os-example-lorawan code.
https://github.com/kvkc97/mbed-os-example-lorawan-lr1110
Since I could not attach the mbed-os library and the changes, i is attached in the below link.
https://github.com/kvkc97/mbed-os

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants