Skip to content

Fix broken manifest build and other minor changes #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 22, 2019
Merged

Fix broken manifest build and other minor changes #164

merged 2 commits into from
May 22, 2019

Conversation

dinogun
Copy link
Collaborator

@dinogun dinogun commented May 22, 2019

  1. manifest build is currently broken as the OS and the distro cannot be used interchangeably. Using "os" and "os_family" to indicate "distro" and "generic OS" respectively to reduce code changes.
  2. Remove maintainer LABEL, no longer a standard practice for docker images.
  3. Have jshell as default CMD only for jdk builds and not jre ones.
  4. Add arm64 manifest entries for aarch64.
  5. Added back spaces in the Dockerfiles between statements to keep it readable.

@dinogun
1. manifest build is currently broken as the OS and the distro cannot be
64656c9 
used interchangeably. Using "os" and "os_family" to indicate "distro"
and "generic OS" respectively to reduce code changes.
2. Remove maintainer LABEL, no longer a standard practice for docker images.
3. Have jshell as default CMD only for jdk builds and not jre ones.
4. Add arm64 manifest entries for aarch64.
5. Added back spaces in the Dockerfiles between statements to keep it
readable.
@dinogun dinogun requested a review from gdams May 22, 2019 13:57
@dinogun dinogun merged commit d0ceae4 into AdoptOpenJDK:master May 22, 2019
@dinogun dinogun mentioned this pull request May 22, 2019
Closed
@karianna karianna added this to the May 2019 milestone May 22, 2019
@dinogun
Copy link
Collaborator Author

dinogun commented May 23, 2019

Includes fixes for docker-library/official-images#5710

@dinogun dinogun deleted the official_image_fixes_v2 branch October 20, 2020 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdams gdams gdams approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
May 2019
Development

Successfully merging this pull request may close these issues.
3 participants
@dinogun @gdams @karianna