Add a script to generate the DockerHub config file #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cker images at DockerHub.
karianna
reviewed
May 25, 2019
Addressed earlier review comments.
|
@karianna Thanks for the comments, have updated the script to address your comments. Also added creation of the doc for the unofficial images as well. This should make it easy to copy-paste into the unofficial docker repo everytime we do releases / update the dockerfiles. |
|
@dinogun Looks good but Appveyor is failing? |
|
Have opened issue #173 for tracking the appveyor issue. However this PR has nothing to do with that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for adoptopenjdk official docker images at DockerHub.