Skip to content

#71 - Update images used for full release build from 16.04 to 18.04 for JDK 8/9/10/11 #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2018
Merged

#71 - Update images used for full release build from 16.04 to 18.04 for JDK 8/9/10/11 #76

merged 1 commit into from
Nov 8, 2018

Conversation

grzesuav
Copy link
Contributor

No description provided.

@grzesuav grzesuav mentioned this pull request Oct 25, 2018
Closed
@grzesuav
Copy link
Contributor Author

DCO 1.1 Signed-off-by: Grzegorz Głąb

@dinogun
Copy link
Collaborator

dinogun commented Oct 29, 2018

Can you also update the script that generates the Dockerfiles, you'll find it here

@grzesuav
Copy link
Contributor Author

Sure, weren't aware of those. @dinogun so basically those Dockerfiles are generated via this script ?

@grzesuav
Copy link
Contributor Author

@dinogun done, how actual workflow looks like ? Those Dockerfiles are generated from dockerfile_functions.sh ? I cannot find any usage of that.

@dinogun
Copy link
Collaborator

dinogun commented Nov 2, 2018

dockerfile_functions.sh is sourced in build_latest.sh. It then calls generate_dockerfile() which actually creates the files.

dinogun
dinogun reviewed Nov 2, 2018
View reviewed changes
Copy link
Collaborator

@dinogun dinogun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file 8/jdk/ubuntu/Dockerfile.openj9.releases.full needs to be updated as well. If you make that one change, this can be merged. Thanks !

@grzesuav
Copy link
Contributor Author

grzesuav commented Nov 7, 2018

@dinogun updated

@dinogun dinogun merged commit 047540b into AdoptOpenJDK:master Nov 8, 2018
@grzesuav grzesuav deleted the 71 branch March 11, 2019 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinogun dinogun dinogun left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grzesuav @dinogun @karianna