Skip to content

ITT-141 Automating Services in Java Lib #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Apr 21, 2023
Merged

ITT-141 Automating Services in Java Lib #1001

merged 24 commits into from
Apr 21, 2023

Conversation

jillingk
Copy link
Contributor

@jillingk jillingk commented Apr 18, 2023 •
edited
Loading

Description
Created this draft PR to show progress on the java service automation.
TODO:

  • baseURL formatting (test/live) -> done
  • Overloading methods for non required params -> done
  • Create single file service -> done
  • Method description -> done

@jillingk jillingk marked this pull request as ready for review April 20, 2023 09:53
@jillingk jillingk requested a review from a team April 20, 2023 09:53
@wboereboom
Copy link
Contributor

Should we remove the existing service? Or is it better to deprecate first?

@jillingk
Copy link
Contributor Author

Should we remove the existing service? Or is it better to deprecate first?

@wboereboom difficult to decide tbh. Would be easier to migrate if we deprecate it, but then again we're cluttering the lib quite a lot..

michaelpaul
michaelpaul reviewed Apr 20, 2023
View reviewed changes
michaelpaul
michaelpaul reviewed Apr 20, 2023
View reviewed changes
michaelpaul
michaelpaul previously approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@michaelpaul michaelpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @jillingk! 🚀

@michaelpaul
Copy link
Contributor

The way query string parameters are passed is changing from Map<String, String> to actual method arguments. The order of path, body, and query has also changed.

This change is good and can be done to existing services (e.g. Management and Balance Platform) in a new major release.

@michaelpaul michaelpaul added the Breaking change Indicates a change that has caused a major version update label Apr 20, 2023
wboereboom
wboereboom reviewed Apr 21, 2023
View reviewed changes
@jillingk @wboereboom
Update Makefile
71abe0b 
Co-authored-by: Wouter Boereboom <[email protected]>
wboereboom
wboereboom reviewed Apr 21, 2023
View reviewed changes
@jillingk @wboereboom
Update Makefile
ab28b6e 
Co-authored-by: Wouter Boereboom <[email protected]>
jillingk
jillingk commented Apr 21, 2023
View reviewed changes
@jillingk jillingk requested review from wboereboom and a team April 21, 2023 12:34
@jillingk jillingk merged commit 3d7a575 into develop Apr 21, 2023
@jillingk jillingk deleted the ITT-141 branch April 21, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelpaul michaelpaul michaelpaul approved these changes

@AlexandrosMor AlexandrosMor AlexandrosMor approved these changes

@antolo-arch antolo-arch antolo-arch approved these changes

@wboereboom wboereboom Awaiting requested review from wboereboom

Assignees
No one assigned
Labels
Breaking change Indicates a change that has caused a major version update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jillingk @wboereboom @michaelpaul @AlexandrosMor @antolo-arch