ITT-598: Strict OneOf validation for deserialization against multiple models #1054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandrosMor
previously approved these changes
Jun 12, 2023
|
I would prefer some more explicit (unit) testing around the issue to make sure it works, and to make sure we won't break anything else. |
michaelpaul
previously approved these changes
Jun 15, 2023
michaelpaul
changed the title
michaelpaul
changed the title
Validation for oneOf is strict, other models no.
michaelpaul
approved these changes
Jun 19, 2023
There was a problem hiding this comment.
We are making oneOf validation strict to avoid ambiguities and allowing other (simple) models to ignore (new) fields missing from the specifications at the time the library was built.
New fields might eventually appear in responses received by users of old versions. These fields will be ignored instead of crashing. When a user needs the ignored field, one must upgrade to a new library version.
wboereboom
approved these changes
Jun 19, 2023
antolo-arch
approved these changes
Jun 19, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the sweepschedule issue. Check the SweepConfigurationV2Schedule.java class to see how the deserialization has been changed in order to account for the issue.