Skip to content

[ITT-578] GSON->Jackson: checkout #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 26, 2023
Merged

[ITT-578] GSON->Jackson: checkout #1068

merged 2 commits into from
Jun 26, 2023

Conversation

jillingk
Copy link
Contributor

Description
GSON->Jackson: checkout

@jillingk jillingk requested a review from a team June 26, 2023 07:33
michaelpaul
michaelpaul previously approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@michaelpaul michaelpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

wboereboom
wboereboom suggested changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@wboereboom wboereboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I'm assuming the unit tests wil guarantee proper (de)serialisation.
Only thing I could find is some small issues with deprecation annotations

@jillingk
Copy link
Contributor Author

Fixed the deprecation tag @wboereboom @michaelpaul

@jillingk jillingk requested a review from a team June 26, 2023 10:15
@jillingk jillingk requested a review from michaelpaul June 26, 2023 12:26
@jillingk jillingk merged commit ae39769 into develop Jun 26, 2023
@jillingk jillingk deleted the ITT-578#1 branch June 26, 2023 14:15
@AdyenAutomationBot AdyenAutomationBot mentioned this pull request Jun 26, 2023
Closed
@wboereboom wboereboom added the Breaking change Indicates a change that has caused a major version update label Jun 27, 2023
jillingk added a commit that referenced this pull request Jul 11, 2023
@jillingk
[ITT-578] GSON->Jackson: checkout (#1068)
85e96d9 
* GSON->Jackson: checkout

* added @deprecated tag back to template
jillingk added a commit that referenced this pull request Jul 11, 2023
@jillingk
[ITT-578] GSON->Jackson: checkout (#1068)
56b5642 
* GSON->Jackson: checkout

* added @deprecated tag back to template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelpaul michaelpaul michaelpaul approved these changes

@wboereboom wboereboom wboereboom approved these changes

Assignees
No one assigned
Labels
Breaking change Indicates a change that has caused a major version update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jillingk @michaelpaul @wboereboom