HTTP Client wrong encoding #566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Apache Http client uses the ISO-8859-1 encoding for request bodies. This is not compatible with the rest endpoint and the encoding declared in the header of the request (UTF-8). Adyen#565
amortJ
requested review from
abhilash-adyen,
Aleffio,
AlexandrosMor,
martinsrenato,
rkewlani and
saquibsayyad
as code owners
The Apache Http client uses the ISO-8859-1 encoding for request bodies. This is not compatible with the rest endpoint and the encoding declared in the header of the request (UTF-8). Adyen#565
saquibsayyad
approved these changes
Jun 8, 2021
|
Hi @Aleffio, Thanks, |
achawki
approved these changes
Jun 10, 2021
|
Hi @amortJ , |
Aleffio
approved these changes
Jun 10, 2021
|
Hi @Aleffio, i hate to be pushy but we really need these changes released. Thanks. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Apache Http client uses the ISO-8859-1 encoding for request bodies. This is not compatible with the rest endpoint and the encoding declared in the header of the request (UTF-8).
Fixed issue: #565