FOC-47780: Update TerminalCommonNameValidator to support validation of Castles certificates #573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timon-langlotz
requested review from
abhilash-adyen,
Aleffio,
martinsrenato,
rkewlani and
saquibsayyad
as code owners
timon-langlotz
changed the title
Aleffio
approved these changes
Jun 18, 2021
saquibsayyad
approved these changes
Jun 18, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TerminalCommonNameValidator does not support certificates from Castles terminals. Updated the logic in the following way:
S1E)nullcheck for return value fromMatcher.group(int)Tested scenarios
Added tests for
S1ECN.Fixed issue: Partially FOC-47780