Skip to content

Revert "Add AccountEventContainer layer for AccountHolderStatus" (fixes #589) #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2021
Merged

Revert "Add AccountEventContainer layer for AccountHolderStatus" (fixes #589) #595

merged 1 commit into from
Aug 6, 2021

Conversation

RickWieman
Copy link
Contributor

This reverts commit 78129f9.

Description: As discussed in #529, the change from #535 has broken the AccountEvent list. This PR reverts the change, to make it work again.

Tested scenarios: Manual inspection of AccountEvent list.

Fixed issue: #589

@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 29.948% when pulling 52628c6 on RickWieman:revert-fix_accounteventcontainer into 19eda45 on Adyen:develop.

@AlexandrosMor
Copy link
Contributor

AlexandrosMor commented Aug 4, 2021

Hello @RickWieman

Thank you for opening this pr :) Is the AccountEvent removed ? I still see it in docs

regards,
Alexandros

@RickWieman
Copy link
Contributor Author

Hi @AlexandrosMor,

The way of (de)serialising was changed in v5 (I think), to remove all explicit containers from the JSON. That makes it more intuitive. However, for notifications, you explicitly need to set an apiVersion, otherwise they'll fall back to the oldest API specification, which has those containers. That's why @Aleffio introduced the change in #535, but that broke deserialisation of API responses from v6 (the library's default). We confirmed in #529 that setting the apiVersion to 6 on notifications returns the account events in a compatible format, therefore we should revert the change from @Aleffio to be fully compatible with v6.

@Aleffio
Copy link
Contributor

Aleffio commented Aug 4, 2021

@cyattilakiss @AlexandrosMor let's specify in the next release that "older" notifications will not work anymore, and to create new ones merchants need to specify the apiVersion to be 6 in the corresponding api call.
There are also other 'container' fields, which need to be removed as well, will create a ticket for that.

@AlexandrosMor AlexandrosMor merged commit e21ec4e into Adyen:develop Aug 6, 2021
@wboereboom wboereboom mentioned this pull request Aug 19, 2021
@Aleffio Aleffio mentioned this pull request Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants