Hmac validator null-safe check #647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandrosMor
requested review from
Aleffio,
Morerice and
wboereboom
as code owners
Morerice
approved these changes
Nov 4, 2021
wboereboom
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hmac validator is not null safe, because notificationRequestItem.getAdditionalData().get(HMAC_SIGNATURE) returns null if addtionalData does not contain a key "hmacSignature" (or a possible null value for key "hmacSignature").
There is an extra null-safe check implented in this PR
Tested scenarios
Fixed issue:
Fixes #623