[PW-7223] Fix for serializing Date objects to ISO 8601 format for Checkout #853
Conversation
jillingk
requested review from
AlexandrosMor,
wboereboom,
Morerice and
michaelpaul
as code owners
| @@ -159,7 +160,7 @@ public ChannelEnum read(final JsonReader jsonReader) throws IOException { | |||
| private String countryCode = null; | |||
|
|
|||
| @SerializedName("dateOfBirth") | |||
| @JsonAdapter(DateSerializer.class) | |||
| @JsonAdapter(DateTimeISO8601Serializer.class) | |||
| private Date dateOfBirth = null; | |||
There was a problem hiding this comment.
Time is not necessary in this field. I think we can stick to DateSerializer here.
https://docs.adyen.com/api-explorer/Checkout/69/post/paymentSession#request-dateOfBirth
There was a problem hiding this comment.
Actually I thought we could make it easier for ourselves and make this one ISO8601 as well since the format entails YYYY-MM-DD format and filling the field in as such will result in the same format. Plus I tried sending a full ISO8601 string (with timezone) on Postman and the API just accepts that as well, so I feel like everything ISO8601 is the way to go? Let me know what you think :)
There was a problem hiding this comment.
We will be sending/processing a few extra bytes that will be ignored. I hope we can remove this eventually.
Description
Added a custom adapter for date objects in Checkout classes for merchant requesting this. Also added Unit Tests that we can keep and extend when we add with the new solution for generated models, as it's nice to check the Date object to ISO8601 conversion during these upgrades.
Tested scenarios
Unit Tests in DateSerializationTest.java