move common models to specific packages #908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wboereboom
requested review from
AlexandrosMor,
Morerice and
michaelpaul
as code owners
AlexandrosMor
approved these changes
Nov 24, 2022
michaelpaul
reviewed
Nov 24, 2022
|
The thing is that if we ever start to autogenerate these library models we'll overwrite them anyway. so figured it was best to get rid of them now. I think it's better to have duplicates than to deal with the added complexity of shared models between APIs. |
michaelpaul
approved these changes
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move all models that are shared between services to their respective packages
Tested scenarios
Tested through unit tests