Skip to content
This repository was archived by the owner on Oct 27, 2020. It is now read-only.

[ALF-22050] CQ: Allow to recover empty pagings #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/main/java/org/alfresco/query/AbstractCannedQuery.java
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,9 @@ protected List<List<R>> applyPostQueryPaging(List<R> results, CannedQueryPageDet
}
else if (firstResult > availableResults)
{
// Add an empty page to show that the query and the paging worked but returned no results
List<R> page = new ArrayList<R>(0);
pages.add(page);
return pages; // Start of first page is after all results
}

Expand Down
14 changes: 14 additions & 0 deletions src/test/java/org/alfresco/query/CannedQueryTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,20 @@ public void testQueryPagedResults() throws Exception
assertEquals("Incorrect results on page", 3, pages.get(0).size());
assertEquals("Incorrect results on page", 3, pages.get(1).size());
assertTrue("Should have more pages/items", qrOne.hasMoreItems());

// Skip all results to get an empty page
qPageDetails = new CannedQueryPageDetails(10, 3, 1, 2);
params = new CannedQueryParameters(null, qPageDetails, null);
qOne = qfOne.getCannedQuery(params);
qrOne = qOne.execute();
// Check pages
assertEquals("Incorrect number of results", 0, qrOne.getPagedResultCount());
assertEquals("Incorrect number of pages", 1, qrOne.getPageCount());
pages = qrOne.getPages();
assertEquals("Incorrect number of pages", 1, pages.size());
assertEquals("Incorrect results on page", 0, pages.get(0).size());
assertTrue("Should have no more pages/items", !qrOne.hasMoreItems());
assertNotNull("Should have one empty page", qrOne.getPage());
}

@SuppressWarnings("unchecked")
Expand Down