-
-
Notifications
You must be signed in to change notification settings - Fork 50
feat(Mutual Checker): Following icons in blog cards #992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
marcustyphoon
wants to merge
14
commits into
AprilSylph:master
Choose a base branch
from
marcustyphoon:mutual-checker-following
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(Mutual Checker): Following icons in blog cards #992
marcustyphoon
wants to merge
14
commits into
AprilSylph:master
from
marcustyphoon:mutual-checker-following
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0f3a32b to
5f48b41
Compare
437fc63 to
b51972c
Compare
b51972c to
1ac9f98
Compare
1ac9f98 to
5e01613
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is really what I actually wanted the Mutual Checker blog card thing for: the ability to add an icon to blog cards when a user follows you but you don't follow them back as well as when they're a mutual. Oftentimes I'm in a thread somewhere and I see a blog that I think I might recognize, but that I'm not super familiar with as I don't follow them, and being able to see that they're a follower quickly is very convenient.
Obviously this doesn't work if the blog in question is a sideblog, but most of the time when I want this, it works great.
Why not do this for post headers as well? It would be an API request for every unique user whose post you see. Mutual Checker generally only fires API requests for each unique user who you follow whose posts you see, limiting impact.
Testing steps
(except that the tooltips on post headers don't currently work, see Mutual Checker: Make post header icons hoverable again #1779).