This repository was archived by the owner on Mar 4, 2019. It is now read-only.
resolves #26 update to es 1.4 #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit elastic/elasticsearch@10af60b changes how transport module is initialized, breaking HttpBasicServerModule for Guice. - updated depenencies - HttpBasicServerModule inherits calls HttpServerModule's configure, which binds an HttpServerTransport Updated integration tests - new abstract class for common functionality, from which all integration tests inherit. - using the HttpRequestBuilder for bulding the request - abstract class HttpBasicServerPluginIntegrationTest sets the host to localhost, Test requests will also have localhost has requestIp, making tests consistent.
|
@emig is this PR ready to be merged? |
randomizedtesting-runner is not anymore included in the elasticsearch build
emig
pushed a commit
that referenced
this pull request
Jan 19, 2015
…ility
resolves #26 update to ES 1.4.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit elastic/elasticsearch@10af60b
changes how transport module is initialized, breaking HttpBasicServerModule for Guice.
Updated integration tests
tests inherit.
localhost. The test requests will also have localhost, making
tests consistent.